Fix Bazel build #3181
Open
Fix Bazel build #3181
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
requested review from
ahoppen,
bnbarham,
hamishknight,
keith and
rintaro
as code owners
keith
approved these changes
Oct 31, 2025
Member
|
@swift-ci please test |
This comment was marked as off-topic.
This comment was marked as off-topic.
SimplyDanny
force-pushed
the
bazel-build
branch
from
e02e0c0 to
e05854f
Compare
Contributor
Author
|
Could you please approve the workflow once more, @keith? |
Member
|
Started |
SimplyDanny
force-pushed
the
bazel-build
branch
from
e05854f to
4008b89
Compare
SimplyDanny
commented
Nov 4, 2025
SimplyDanny
force-pushed
the
bazel-build
branch
from
4008b89 to
535dfce
Compare
keith
approved these changes
Nov 4, 2025
Member
|
@swift-ci please test |
Member
|
cc @ahoppen is it ok to add a non-blocking job for this? |
Member
|
I’m personally fine with running the Bazel tests in GitHub Actions (thanks for adding them) but I’d like to hear @bnbarham’s opinion as well before merging. |
bnbarham
approved these changes
Nov 10, 2025
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
Adding the PR test SGTM under the same guidelines as the original bazel support was added, ie. you're happy to fix any issues that come up (#1251 (review)). And having PR testing should only help with that I imagine :)
Contributor
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with Bazel doesn't work at the moment. That's mainly due to the missing dependencies for
SwiftRefactorTestandSwiftSyntaxMacros. However, there is also an issue withrules_pythonwhich gets fixed by the update of the Bazel version.To alleviate the risk of causing an outdated Bazel configuration again, I also added an action that at least builds everything in PRs.